Conversation
fix(PM-1192): showing wrong review scorecard link
Previously, the sorting failed when getFinal() returned undefined. Now we fallback to getSubmissionDate() in case of anonymous user Fixes PM-1055
Fix(registrants): sort by submitted date correctly
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| phases, | ||
| } = challenge; | ||
|
|
||
| const getScoreCardByPhase = (phaseName) => { |
There was a problem hiding this comment.
Consider adding error handling or a default return value in getScoreCardByPhase in case phases is undefined or does not contain the expected structure. This will prevent potential runtime errors.
| } = challenge; | ||
|
|
||
| const getScoreCardByPhase = (phaseName) => { | ||
| const phase = phases.find(item => item.name === phaseName); |
There was a problem hiding this comment.
The find method will return undefined if no matching phase is found. Ensure that phase is checked before attempting to access phase.constraints to avoid potential errors.
|
|
||
| const getScoreCardByPhase = (phaseName) => { | ||
| const phase = phases.find(item => item.name === phaseName); | ||
| const scoreCardConstraint = phase && phase.constraints && phase.constraints.find(item => item.name === 'Scorecard'); |
There was a problem hiding this comment.
Consider checking if phase.constraints is an array before calling find on it to prevent runtime errors if constraints is not defined or not an array.
| }), | ||
| metadata: PT.array, | ||
| events: PT.arrayOf(PT.string), | ||
| phases: PT.arrayOf(PT.any), |
There was a problem hiding this comment.
Using PT.any for phases prop type is not specific and can lead to potential issues with type checking. Consider defining a more specific prop type that accurately reflects the expected structure of the phases array.
2 participants
https://topcoder.atlassian.net/browse/PM-1055
https://topcoder.atlassian.net/browse/PM-1192